A Code Review 1

What this C++ code-review question tests

This is an easy difficulty question designed to assess your ability to spot common pitfalls and subtle bugs in C++ code. Code-review skills are valued across trading firms and financial software teams, where correctness and clarity directly affect system reliability.

To approach questions like this, read the snippet carefully for logic errors, undefined behaviour, resource leaks, type mismatches, or violations of C++ semantics. The question may test knowledge of pointer lifetime, memory management, operator precedence, scoping rules, or standard-library usage. Strong candidates explain not just what is wrong, but why it matters and how they would fix it.

• Pointer and reference semantics
• Memory ownership and lifetime
• Undefined behaviour in C++
• Type safety and implicit conversions
• Standard-library idioms